Changeset 64529 for trunk/wp-settings.php

Timestamp:

11/10/2026 04:00:02 PM (9 hours ago)

Author:

whyisjake

Message:

Security: Make the Secrets API extension points abstract classes.

WP_Secrets_Provider, WP_Secrets_Store and WP_Secrets_Keyring were interfaces. Once they ship, adding a method to one would be a fatal error in every secrets.php drop-in that implements it, so they could never change. As abstract classes, a later release can add a method with a default implementation and existing drop-ins keep working.

The method signatures are unchanged. The three files are renamed from interface-wp-secrets-*.php to class-wp-secrets-*.php, and the default and fail-closed implementations now extend the classes.

A drop-in written against the interfaces must change implements to extends. Until it does, loading it is a fatal error.

Follow-up to r64337, r65375.

Props ericmann, jorbin.
See #66187.

Built from ​https://develop.svn.wordpress.org/trunk@65390

File:

• trunk/wp-settings.php (modified) (1 diff)

trunk/wp-settings.php

@@ -325 +325 @@
 require ABSPATH . WPINC . '/secrets/class-wp-secret-version.php';
 require ABSPATH . WPINC . '/secrets/class-wp-secret.php';
-require ABSPATH . WPINC . '/secrets/interface-wp-secrets-provider.php';
-require ABSPATH . WPINC . '/secrets/interface-wp-secrets-keyring.php';
-require ABSPATH . WPINC . '/secrets/interface-wp-secrets-store.php';
+require ABSPATH . WPINC . '/secrets/class-wp-secrets-provider.php';
+require ABSPATH . WPINC . '/secrets/class-wp-secrets-keyring.php';
+require ABSPATH . WPINC . '/secrets/class-wp-secrets-store.php';
 require ABSPATH . WPINC . '/secrets/class-wp-secrets-config-key-provider.php';
 require ABSPATH . WPINC . '/secrets/class-wp-secrets-broken-keyring.php';